Skip to content

fix(cc-components): show dialed number instead of entrypoint for outdial calls #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhabalan wants to merge 1 commit into from
Closed

fix(cc-components): show dialed number instead of entrypoint for outdial calls #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ages/contact-center/cc-components/src/components/task/CallControlCAD/call-control-cad.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,14 @@ const CallControlCADComponent: React.FC<CallControlComponentProps> = (props) =>
const customerName = currentTask?.data?.interaction?.callAssociatedDetails?.customerName;

//@ts-expect-error To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762
const ani = currentTask?.data?.interaction?.callAssociatedDetails?.ani;
const rawAni = currentTask?.data?.interaction?.callAssociatedDetails?.ani;
//@ts-expect-error To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762
const dn = currentTask?.data?.interaction?.callAssociatedDetails?.dn;
const rawDn = currentTask?.data?.interaction?.callAssociatedDetails?.dn;

// For outdial calls, swap ani and dn so the dialed number is shown as the primary identifier
const isOutdial = !!currentTask?.data?.interaction?.outboundType;
const ani = isOutdial ? rawDn || rawAni : rawAni;
const dn = isOutdial ? rawAni || rawDn : rawDn;

// Create unique IDs for tooltips
const customerNameTriggerId = `customer-name-trigger-${currentTask.data.interaction.interactionId}`;
Expand Down
7 changes: 6 additions & 1 deletion ...ges/contact-center/cc-components/src/components/task/IncomingTask/incoming-task.utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,17 @@ export const extractIncomingTaskData = (
//@ts-expect-error To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762
const callAssociationDetails = incomingTask?.data?.interaction?.callAssociatedDetails;
const ani = callAssociationDetails?.ani;
const dn = callAssociationDetails?.dn;
const customerName = callAssociationDetails?.customerName;
const virtualTeamName = callAssociationDetails?.virtualTeamName;
const ronaTimeout = callAssociationDetails?.ronaTimeout ? Number(callAssociationDetails?.ronaTimeout) : null;
const startTimeStamp = incomingTask?.data?.interaction?.createdTimestamp;
const mediaType = incomingTask.data.interaction.mediaType;
const mediaChannel = incomingTask.data.interaction.mediaChannel;

// Check if this is an outdial call
const isOutdial = !!incomingTask?.data?.interaction?.outboundType;

// Compute media type flags
const isTelephony = mediaType === MEDIA_CHANNEL.TELEPHONY;
const isSocial = mediaType === MEDIA_CHANNEL.SOCIAL;
Expand All @@ -56,7 +60,8 @@ export const extractIncomingTaskData = (
const declineText = !incomingTask.data.wrapUpRequired && isTelephony && isBrowser ? 'Decline' : undefined;

// Compute title based on media type
const title = isSocial ? customerName : ani;
// For outdial calls, show the dialed number (dn) instead of the entrypoint number (ani)
const title = isSocial ? customerName : isOutdial ? dn || ani : ani;

// Compute disable state for accept button when auto-answering
const isAutoAnswering = incomingTask.data.isAutoAnswering || false;
Expand Down
7 changes: 6 additions & 1 deletion packages/contact-center/cc-components/src/components/task/TaskList/task-list.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export const extractTaskListItemData = (
//@ts-expect-error To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762
const callAssociationDetails = task?.data?.interaction?.callAssociatedDetails;
const ani = callAssociationDetails?.ani;
const dn = callAssociationDetails?.dn;
const customerName = callAssociationDetails?.customerName;
const virtualTeamName = callAssociationDetails?.virtualTeamName;

Expand All @@ -29,6 +30,9 @@ export const extractTaskListItemData = (
const mediaType = task.data.interaction.mediaType;
const mediaChannel = task.data.interaction.mediaChannel;

// Check if this is an outdial call
const isOutdial = !!task?.data?.interaction?.outboundType;

// Compute media type flags
const isTelephony = mediaType === MEDIA_CHANNEL.TELEPHONY;
const isSocial = mediaType === MEDIA_CHANNEL.SOCIAL;
Expand All @@ -39,7 +43,8 @@ export const extractTaskListItemData = (
const declineText = isTaskIncoming && isTelephony && isBrowser ? 'Decline' : undefined;

// Compute title based on media type
const title = isSocial ? customerName : ani;
// For outdial calls, show the dialed number (dn) instead of the entrypoint number (ani)
const title = isSocial ? customerName : isOutdial ? dn || ani : ani;

const isAutoAnswering = task.data.isAutoAnswering || false;

Expand Down