Add env-var for image-name and manual dispatch to build workflow#373
Open
Wuodan wants to merge 3 commits intonikolaik:mainfrom
Open
Add env-var for image-name and manual dispatch to build workflow#373Wuodan wants to merge 3 commits intonikolaik:mainfrom
Wuodan wants to merge 3 commits intonikolaik:mainfrom
Conversation
Keep nikolaik/python-nodejs as the default image name in the workflow, but resolve it through a GitHub Actions variable so forks can publish to a different image without changing the repository. Forks can set IMAGE_NAME in Actions variables or in workflow run configuration. That keeps the default behavior unchanged here while avoiding fork-specific edits in PRs.
Allow manual workflow runs from GitHub Actions with a force option and an optional IMAGE_NAME override. This makes it possible to test publish flows without overwriting the real published images tags.
This was referenced Mar 17, 2026
nikolaik
reviewed
Mar 18, 2026
Owner
nikolaik
left a comment
There was a problem hiding this comment.
Thanks for all your PRs Stefan <3
Made a few stylistic comments on this one
Address review feedback on PR nikolaik#373 by renaming the manual image override input and reformatting long shell commands for readability.
Author
|
Thank you for this open source repo! I updated this PR #373 and merged the changes into the other 2 PRs #375 and #377 with a small fix in #375. Test-runs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some small changes to allow
My other PRs will include these 2 base commits, you or others may find them useful too.