Make latest a post-build multi-arch alias#374
Closed
Wuodan wants to merge 3 commits intonikolaik:mainfrom
Closed
Conversation
Keep nikolaik/python-nodejs as the default image name in the workflow, but resolve it through a GitHub Actions variable so forks can publish to a different image without changing the repository. Forks can set IMAGE_NAME in Actions variables or in workflow run configuration. That keeps the default behavior unchanged here while avoiding fork-specific edits in PRs.
Allow manual workflow runs from GitHub Actions with a force option and an optional IMAGE_NAME override. This makes it possible to test publish flows without overwriting the real published images tags.
Wuodan
force-pushed
the
upstream-PR/01-fix-latest-tag-missing-for-arm64
branch
from
b6d7e71 to
cd6fec5
Compare
Determine the canonical latest image from the current build set and publish `latest` after the multi-arch images have been built. This replaces the separate `latest` build path with a post-build tag publish, so `latest` is published for all supported architectures. Use `regctl image copy` to retag the canonical multi-arch image without rebuilding it. This also avoids additional authenticated registry reads during latest-tag publication, which helps stay clear of Docker Hub pull-rate limits. Remove the root Dockerfile because it only existed for the separate Docker Hub Automated Build path. Any Docker Hub automated build still configured to use that file must be disabled in Docker Hub. Fixes nikolaik#263.
Wuodan
force-pushed
the
upstream-PR/01-fix-latest-tag-missing-for-arm64
branch
from
cd6fec5 to
c0ee392
Compare
Author
|
This solution with tagging The better way is to add I'm closing this PR and will open a new one for the other solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determine the canonical latest image from the current build set and publish
latestafter the multi-arch images have been built.This replaces the separate
latestbuild path with a post-build tag publish, solatestis published for all supported architectures. Useregctl image copyto retag the canonical multi-arch image without rebuilding it.This also avoids additional authenticated registry reads during latest-tag publication, which helps stay clear of Docker Hub pull-rate limits.
Remove the root Dockerfile because it only existed for the separate Docker Hub Automated Build path. Any Docker Hub automated build still configured to use that file must be disabled in Docker Hub.
Fixes #263.