Allow constructing recursive MapDiffer that uses itself #103
Open
JeroenDeDauw wants to merge 2 commits intomasterfrom
Open
Allow constructing recursive MapDiffer that uses itself #103JeroenDeDauw wants to merge 2 commits intomasterfrom
JeroenDeDauw wants to merge 2 commits intomasterfrom
Conversation
Closed
Collaborator
Author
|
@BoShurik I made a follow up, now it should be ready for merging. Really a hacky solution though. Making this follow up made me realize how strange it is that the Differ return an array of DiffOp rather than a Diff. I don't see any reason for that. If they returned a Diff, we'd not have the problem in MapDiffer, that it needs to know if the inner differ is associative or not. I'm thinking of just creating a version 4.0 that
So I am not comfortable with merging this without review from someone else that thinks this is OK. |
df771f5 to
6357386
Compare
Collaborator
Author
|
Another non-big-changes approach that avoids introducing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98