fix(cc-components): show dialed number instead of entrypoint for outdial calls#657
Open
bhabalan wants to merge 2 commits intowebex:nextfrom
Open
fix(cc-components): show dialed number instead of entrypoint for outdial calls#657bhabalan wants to merge 2 commits intowebex:nextfrom
bhabalan wants to merge 2 commits intowebex:nextfrom
Conversation
…ial calls When making an outdial call via dialpad, the incoming task, task list, and active task were incorrectly showing the entrypoint number (ANI) instead of the actual dialed number (DN). This fix checks for outboundType === 'OUTDIAL' and uses the DN field from callAssociatedDetails for the title display. CAI-7359
bhabalan
commented
Mar 18, 2026
| }); | ||
| }); | ||
|
|
||
| describe('Outdial tasks', () => { |
Contributor
Author
There was a problem hiding this comment.
Add more comprehensive tests
Contributor
Author
There was a problem hiding this comment.
Added 8 comprehensive test cases (4 for IncomingTask, 4 for TaskList) covering:
- Empty
dnstring fallback toani CALLBACKoutboundType correctly usesani(notdn)- Social media outdial tasks use
customerName - Non-browser outdial button states (
Ringing..., disabled accept)
Also fixed 3 prettier lint errors in source files. All 646 tests passing.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…lint errors Add 4 new test cases each for IncomingTask and TaskList outdial scenarios: - Empty dn string fallback to ani - CALLBACK outboundType uses ani (not dn) - Social media outdial uses customerName - Non-browser outdial button states Fix prettier formatting in source files. CAI-7359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES
https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7359
This pull request addresses
When making an outdial call via the dialpad, the incoming task, task list, and active task widgets incorrectly display the entrypoint number (ANI) instead of the actual dialed number (DN). This affects all three task display surfaces: IncomingTask, TaskList, and CallControlCAD.
by making the following changes
extractIncomingTaskDatainincoming-task.utils.tsxto checkoutboundType === 'OUTDIAL'and usedn(dialed number) instead ofanifor the titleextractTaskListItemDataintask-list.utils.tsfor the task list displayCallControlCADcomponent to showdnas the primary caller identifier for outdial callsaniifdnis not available, maintaining backward compatibilityChange Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.