fix(cc-widgets): update station login component to use international dialing prop#654
fix(cc-widgets): update station login component to use international dialing prop#654zachraymer merged 16 commits intowebex:nextfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e59fef407
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/contact-center/cc-components/src/components/StationLogin/station-login.utils.tsx
Show resolved
Hide resolved
packages/contact-center/cc-components/src/components/StationLogin/station-login.utils.tsx
Show resolved
Hide resolved
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
packages/contact-center/cc-components/src/components/StationLogin/station-login.types.ts
Outdated
Show resolved
Hide resolved
mkesavan13
left a comment
There was a problem hiding this comment.
- Kindly add this toggle to sample app
- Add a tiny VidCast of testing this change
packages/contact-center/cc-components/src/components/StationLogin/station-login.tsx
Show resolved
Hide resolved
packages/contact-center/cc-components/src/components/StationLogin/station-login.types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dcaa28f9b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/contact-center/cc-components/src/components/StationLogin/station-login.tsx
Show resolved
Hide resolved
|
https://app.vidcast.io/share/1d2fd0d0-c8cd-4c14-ae91-7cb84704fc73?playerMode=vidcast |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f98737c56
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7303
This pull request addresses
International dialing is now a station login prop so that consuming applications can use ff gating to enable
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
Adds the internationaDialNumber prop to station login component
Changes the dial number regex logic to use international format if passed as prop
Falls back to agent config regex or US format
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.