fix(notify): remove INFO notifications that block cmdheight=0#447
Closed
barrettruth wants to merge 1 commit intowallpants:mainfrom
Closed
fix(notify): remove INFO notifications that block cmdheight=0#447barrettruth wants to merge 1 commit intowallpants:mainfrom
barrettruth wants to merge 1 commit intowallpants:mainfrom
Conversation
Problem: vim.notify at INFO level writes to the command line area. With cmdheight=0 there is no space, so Neovim forces a "Press ENTER" prompt on every :GithubPreviewStart and :GithubPreviewStop. Solution: remove the redundant "init" notification entirely and switch the "goodbye" notification to nvim_echo with history=false so it displays transiently without requiring command line space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vim.notifyat INFO level writes to the command line area. Withcmdheight=0there is no space for it, so Neovim forces a "Press ENTER" prompt on every:GithubPreviewStartand:GithubPreviewStop.Solution
Remove the redundant "init" notification entirely (the browser opening is confirmation enough) and switch the "goodbye" notification to
nvim_echowithhistory=falseso it displays transiently without requiring command line space.