fix(bun): notify user when bun is not installed#446
Closed
barrettruth wants to merge 1 commit intowallpants:mainfrom
Closed
fix(bun): notify user when bun is not installed#446barrettruth wants to merge 1 commit intowallpants:mainfrom
barrettruth wants to merge 1 commit intowallpants:mainfrom
Conversation
Problem: when bun is not in PATH, GithubPreviewToggle silently fails
because jobstart returns without error and produces no visible output.
Solution: check vim.fn.executable("bun") at the top of start() and
show an ERROR-level notification with install instructions before any
jobs are spawned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When bun is not installed, running
GithubPreviewTogglesilently fails.jobstartreturns without error and produces no visible output, leaving the user with no indication of what went wrong.Solution
Check
vim.fn.executable("bun")at the top ofstart()and show anERROR-level notification with install instructions before any jobs are spawned.