Remove references to old i_blanket_type types#4124
Open
athoynilimanew wants to merge 5 commits intoukaea:mainfrom
Open
Remove references to old i_blanket_type types#4124athoynilimanew wants to merge 5 commits intoukaea:mainfrom
i_blanket_type types#4124athoynilimanew wants to merge 5 commits intoukaea:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4124 +/- ##
=======================================
Coverage 47.51% 47.51%
=======================================
Files 141 141
Lines 29487 29479 -8
=======================================
- Hits 14010 14008 -2
+ Misses 15477 15471 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
i_blanket_type types
timothy-nunn
requested changes
Mar 16, 2026
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
We can remove the constraint description since the actual constraint has been removed
| * (53) Neutron fluence on TF coil upper limit (itv 92,93,94) | ||
| * (54) Peak TF coil nuclear heating upper limit (itv 95,93,94) | ||
| * (55) Vacuum vessel helium concentration upper limit i_blanket_type =2 (itv 96,93,94) | ||
| * (55) Vacuum vessel helium concentration upper limit #REMOVED i_blanket_type =2 (itv 96,93,94) #REMOVED |
Collaborator
There was a problem hiding this comment.
Suggested change
| * (55) Vacuum vessel helium concentration upper limit #REMOVED i_blanket_type =2 (itv 96,93,94) #REMOVED | |
| * (55) NOT USED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #4071
@timothy-nunn do we also need to delete variables e.g. densbreed, breedmat that is only used for
i_blanket_type=2?
Checklist
I confirm that I have completed the following checks: