Skip to content

Remove references to old i_blanket_type types#4124

Open
athoynilimanew wants to merge 5 commits intoukaea:mainfrom
athoynilimanew:anilima/papercut_blanket_references_#4071
Open

Remove references to old i_blanket_type types#4124
athoynilimanew wants to merge 5 commits intoukaea:mainfrom
athoynilimanew:anilima/papercut_blanket_references_#4071

Conversation

@athoynilimanew
Copy link
Collaborator

@athoynilimanew athoynilimanew commented Mar 9, 2026

Description

closes #4071

@timothy-nunn do we also need to delete variables e.g. densbreed, breedmat that is only used for
i_blanket_type=2?

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@athoynilimanew athoynilimanew marked this pull request as ready for review March 9, 2026 09:06
@athoynilimanew athoynilimanew requested a review from a team as a code owner March 9, 2026 09:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.51%. Comparing base (67340b1) to head (43db455).

Files with missing lines Patch % Lines
process/models/power.py 0.00% 3 Missing ⚠️
process/models/costs/costs.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4124   +/-   ##
=======================================
  Coverage   47.51%   47.51%           
=======================================
  Files         141      141           
  Lines       29487    29479    -8     
=======================================
- Hits        14010    14008    -2     
+ Misses      15477    15471    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn changed the title Papercut blanket references #4071 Remove references to old i_blanket_type types Mar 16, 2026
Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the constraint description since the actual constraint has been removed

* (53) Neutron fluence on TF coil upper limit (itv 92,93,94)
* (54) Peak TF coil nuclear heating upper limit (itv 95,93,94)
* (55) Vacuum vessel helium concentration upper limit i_blanket_type =2 (itv 96,93,94)
* (55) Vacuum vessel helium concentration upper limit #REMOVED i_blanket_type =2 (itv 96,93,94) #REMOVED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* (55) Vacuum vessel helium concentration upper limit #REMOVED i_blanket_type =2 (itv 96,93,94) #REMOVED
* (55) NOT USED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove references to old i_blanket_type types

3 participants