Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
==========================================
- Coverage 91.92% 91.68% -0.24%
==========================================
Files 37 38 +1
Lines 32153 32237 +84
Branches 5143 5156 +13
==========================================
Hits 29556 29556
- Misses 2264 2348 +84
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
petrelharp
force-pushed
the
json-struct-c-docs
branch
2 times, most recently
from
f4ed750 to
f1593cc
Compare
petrelharp
force-pushed
the
json-struct-c-docs
branch
from
f1593cc to
9adfdb9
Compare
bhaller
reviewed
Mar 21, 2026
petrelharp
force-pushed
the
json-struct-c-docs
branch
2 times, most recently
from
75037d5 to
abaaa1d
Compare
Closed
Contributor
Author
|
Codecov is complaining because the example C file is not being hit. AFAICT this is expected, and perhaps we should change this line to ask codecov to just cover |
petrelharp
force-pushed
the
json-struct-c-docs
branch
from
abaaa1d to
a8473fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that removing the json+struct C code from tskit itself and providing an example in the C docs is probably the way to go. @bhaller provided the C code, modified from the method and tests in #3437.
Currently this has the additional docs that are also in #3440.