Fix spurious assertion in split_disjoint_nodes (issue #497)#509
Merged
nspope merged 1 commit intotskit-dev:mainfrom Mar 20, 2026
Merged
Fix spurious assertion in split_disjoint_nodes (issue #497)#509nspope merged 1 commit intotskit-dev:mainfrom
split_disjoint_nodes (issue #497)#509nspope merged 1 commit intotskit-dev:mainfrom
Conversation
Contributor
Author
|
@hyanwong do you mind if I merge this (small but important) fix? |
hyanwong
approved these changes
Mar 20, 2026
…es; and sorting after simplify in preprocess_ts
hyanwong
force-pushed
the
split-disjoint-fix
branch
from
b888632 to
863bc35
Compare
Contributor
Author
|
Commit you pushed will change the python version in the CI, is that intended @hyanwong ? Might be better to do that in a separate PR? |
Member
|
Hmm, I just rebased from current main, or so I thought? |
Contributor
Author
|
The merge queue is stuck---at two attempts, tests all past but the lint check hangs on "waiting for status to be reported". I'm just going to bypass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.