fix: process.exit(0) after main() prevents Node event loop hang#252
Merged
fix: process.exit(0) after main() prevents Node event loop hang#252
Conversation
The compiled tps binary (Node) kept the event loop alive after read-only commands (mail log, mail list, etc.) because Node's event loop doesn't exit while open handles exist (e.g. lingering timers from imports). Bun exits cleanly because it is more aggressive about draining the event loop. Fix: chain .then(() => process.exit(0)) on main() so the process always exits after the command completes, regardless of open handles. Commands that intentionally stay alive (tps mail watch, tps branch start, etc.) already call process.exit() explicitly via SIGINT/SIGTERM handlers, so this doesn't affect them.
heskew
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Compiled
tpsbinary (Node) hangs after read-only commands likemail log,mail list, etc.bun runexits cleanly because Bun is more aggressive about draining the event loop. Node keeps alive due to open handles from imports/timers.Fix
One line: chain
.then(() => process.exit(0))onmain().Commands that intentionally stay alive (
tps mail watch,tps branch start) already callprocess.exit()explicitly via their own signal handlers — unaffected.693 passing, 4 pre-existing failures.