Fix Spin2 ABORT/CATCH#509
Merged
totalspectrum merged 1 commit intototalspectrum:masterfrom Mar 15, 2026
Merged
Conversation
Contributor
Author
|
(The total lack of tests with this feature is quite dire) |
Owner
|
Thanks again, Ada, I'm glad you caught this. Yes, we need more tests :(. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This became chuper broken at 98e32c2 when you tried to correct the return value (I still think the way Spin2 does it is really stupid). If you never evaluate
ast->left, that actually gets rid of the whole call I'm trying to do, ooops!Maybe using the bool operator is a bit of a hack, but codegen seems fine to me.
This broke the Spin Hexagon P2 port.