Open
Conversation
… a route and link to the new page
… in CreateAccount.jsx to utillize `addUserToDatabase` function for account creation. Added name input for account creation.
…d utility class whitespace-nowrap to prevent text from wrapping within its container.
…ect the user to the homepage to create a new list.
…k in the nav bar depending on if a user is signed in or not.
|
Visit the preview URL for this PR (updated for commit a51aabb): https://tcl-76-smart-shopping-list--pr68-mp-create-snapshop-a-hfp4qb3c.web.app (expires Fri, 25 Oct 2024 12:07:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 512b1a88be8ae05fd3e727b99332819df760271d |
sar-mko
reviewed
Oct 23, 2024
Collaborator
sar-mko
left a comment
There was a problem hiding this comment.
I was able to make two accounts one that was gmail and one that wasn't. And so only the gmail can get authorized and re-logged into.
Though I am wondering if there's a way that we can just use the firebase CLI pop up instead of having a create account page for the time being? It's confusing because we can sign up with any kind of email, but the sign in uses the firebase popup, and it does google verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a user, I want an account connected to SnapShop
This code allows for a user to create an account using a google email. Once they have created an account, they will be redirected to the homepage to start creating lists. The Create Account link is conditionally rendered dependent on if someone is signed in or not.
Acceptance Criteria
Type of Changes
featureTesting Steps / QA Criteria