Skip to content

docs: trim swamp-extension-model skill to restore 100% content score#864

Closed
stack72 wants to merge 1 commit intomainfrom
docs/trim-extension-model-skill
Closed

docs: trim swamp-extension-model skill to restore 100% content score#864
stack72 wants to merge 1 commit intomainfrom
docs/trim-extension-model-skill

Conversation

@stack72
Copy link
Contributor

@stack72 stack72 commented Mar 25, 2026

Summary

The swamp-extension-model skill dropped to 93% overall (85% content) in the latest skill review CI run (#861). The tessl content judge scored conciseness 2/3 with the reasoning: "some redundant explanations could be tightened". The validation check also flagged a hard warning: SKILL.md was 560 lines against a 500-line max.

Root cause: the skill had grown incrementally across several PRs (#826, #850, #860, #861) and accumulated sections whose detailed content was already fully covered in the references/ files — violating the skill-creator principle of "information should live in either SKILL.md or references, not both".

Changes to SKILL.md

Six targeted cuts, no content removed from references:

  1. Resources & Files — removed the duplicate state resource spec code block (identical example exists in references/api.md); replaced with a one-line pointer to api.md
  2. Execute Function — replaced the 20-line annotated code block (context property comments + example body) with a concise inline property list and pointer to api.md; the full API is already documented there
  3. Error Handling — removed the duplicate execute code block (exact match in references/api.md#error-handling); kept the prose rule (throw before writing data) and the allowFailure note
  4. Factory Models — collapsed the TypeScript loop + CEL YAML block into a single prose sentence describing the pattern, with a pointer to references/scenarios.md for the full example
  5. Extending Existing Model Types — replaced the full shell_audit.ts TypeScript example (verbatim in references/examples.md) with a pointer to that reference; kept the extension rules list
  6. Publishing Extensions — removed the content-path paragraph (word-for-word duplicate of references/publishing.md)

Result

Metric Before After
SKILL.md lines 560 461
Line count check ⚠️ warning (560 > 500) ✅ passed
Content score 85% 100%
Overall review score 93% 100%

All four content dimensions now 3/3: conciseness, actionability, workflow clarity, progressive disclosure.

Test plan

  • npx tessl skill review .claude/skills/swamp-extension-model --json → 100% locally verified
  • Skill Review CI job passes at 100%

🤖 Generated with Claude Code

@stack72 stack72 force-pushed the docs/trim-extension-model-skill branch from 6f34d8b to 0a2aceb Compare March 25, 2026 17:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Blocking Issues

  1. Empty PR — no file changes present. The PR description details six targeted cuts to .claude/skills/swamp-extension-model/SKILL.md, but the diff contains 0 changed files. The GitHub compare API confirms the branch has no file changes relative to main. The described trimming work either was not committed, was committed to a different branch, or was already merged into main before this PR was opened. The PR cannot be merged in its current state as it would be a no-op.

Suggestions

None — the content of the described changes sounds reasonable, but there is nothing to review until the actual file changes are present in the PR.

@stack72 stack72 closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant