Add image args for build linux arm64#830
Merged
Technoboy- merged 3 commits intomasterfrom Mar 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a configurable base image build argument for the Pulsar functions runner images, to support alternative base images (e.g., for linux/arm64 builds).
Changes:
- Add a
BASE_IMAGEbuild arg to the Java and Python runner Dockerfiles and use it for the final stageFROM. - Add a
BASE_IMAGEbuild arg to the Go runner Dockerfile and switchFROMto reference it.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| images/pulsar-functions-python-runner/Dockerfile | Adds BASE_IMAGE arg and uses it for the runner stage base image. |
| images/pulsar-functions-java-runner/Dockerfile | Adds BASE_IMAGE arg and uses it for the runner stage base image. |
| images/pulsar-functions-go-runner/Dockerfile | Adds BASE_IMAGE arg and uses it for the (single) base image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
freeznet
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add image args for build linux arm64
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)