fix: Enable Demo/Stack installations in non-default namespaces#374
fix: Enable Demo/Stack installations in non-default namespaces#374
Conversation
xeniape
changed the title
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Looks like it's going into a good direction, thanks!
stacks/stacks-v2.yaml
Outdated
| cpu: 5000m | ||
| pvc: 5Gi | ||
| parameters: | ||
| - name: stackLabel |
There was a problem hiding this comment.
I think instead of copy/pasting this and adopting the label (error prone) I would let the Rust code of stackablectl set the stack (and optional demo) templating variable. It's been a while, but you should be able to look at the NAMESPACE variable as an example. In which case it might make sense to call it e.g. STACK and DEMO for consistency
There was a problem hiding this comment.
Yeah, that sounds reasonable, I'll look into that
There was a problem hiding this comment.
decf874 (this PR) but with this, this PR is now blocked on stackabletech/stackable-cockpit#429, should be merged after that one
demos/demos-v2.yaml
Outdated
| memory: 15Gi | ||
| pvc: 15Gi | ||
| parameters: | ||
| - name: demoLabel |
There was a problem hiding this comment.
Same as with the stack variable above/below
|
Only merge this one after stackabletech/stackable-cockpit#429 is merged (because of the |
2 participants
Part of stackabletech/stackable-cockpit#187
This PR parameterizes places where
defaultwas hard-coded previously, enabling demo/stack installation in non-default namesplaces. Adds demo/stack labels. Fixes some minor broken demos.