fix: type checks for consistency when the same parameter is repeated (#4332, #4336)#4335
Open
qykr wants to merge 13 commits intosqlc-dev:mainfrom
Open
fix: type checks for consistency when the same parameter is repeated (#4332, #4336)#4335qykr wants to merge 13 commits intosqlc-dev:mainfrom
qykr wants to merge 13 commits intosqlc-dev:mainfrom
Conversation
Author
|
Also fixed a typo: -- internal/endtoend/testdata/params_placeholder_in_left_expr/postgresql/query.sql
SELECT * FROM users WHERE $1 = id;
-- name: FindByIDAndName :many
SELECT * FROM users WHERE $1 = id AND $1 = name;I'm pretty sure having $1 repeated twice there is a typo, at least. Also made the name auto inference engine a bit more powerful, from: // internal/endtoend/testdata/select_subquery/postgresql/stdlib/go/query.sql.go
type SubqueryParams struct {
Column1 sql.NullString
Column2 sql.NullInt32
}to: // internal/endtoend/testdata/select_subquery/postgresql/stdlib/go/query.sql.go
type SubqueryParams struct {
Alias sql.NullString
A int32
}This was also one of the buggy e2e's described in #4336 by the way |
Author
|
Some may question whether or not using $1 multiple times should to be supported.
My error ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4332, #4336, adds a new
invalid_reused_param_typee2e and fixes many existing ones.