fix(sqlite): disable positional indexing when sqlc.slice is present#4330
Open
noxymon wants to merge 2 commits intosqlc-dev:mainfrom
Open
fix(sqlite): disable positional indexing when sqlc.slice is present#4330noxymon wants to merge 2 commits intosqlc-dev:mainfrom
noxymon wants to merge 2 commits intosqlc-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully fixes #4213
Problem:
In SQLite, sqlc uses positional parameters (e.g., ?1, ?2) to support named parameter reuse. However, sqlc.slice expands at runtime into a variable number of placeholders via strings.Replace. If a named parameter follows a slice, its compile-time
index (e.g., ?2) becomes invalid at runtime because the slice expansion shifted the actual argument positions in the underlying driver call. This leads to runtime data corruption as parameters pick up the wrong values.
Solution:
This PR modifies the SQLite rewriter to detect if a sqlc.slice is present in the query. If a slice is detected, named parameter support (positional indexing) is disabled for that specific query. This forces the rewriter to use simple ? placeholders
and the Go generator to append every parameter occurrence to the queryParams slice. This approach is inherently safe against dynamic placeholder expansion and matches the proven behavior of the MySQL generator.
Verification: