draft: chore/prepare release v2

[matsk-sinch]

No description provided.

[matsk-sinch]

Code review

2 issues found:

---

Issue 1: Missing space in error messages

File: sinch/core/clients/sinch_client_configuration.py
Functions: get_sms_origin_for_auth() and get_conversation_origin()

Python implicit string concatenation produces malformed error messages. The two adjacent string literals have no space between them:

# Current (broken):
"Example: SinchClient(..., sms_region='eu')"
"or set it via sinch_client.configuration.sms_region. "
# Produces: "...sms_region='eu')or set it via..."

Fix: Add a leading space to the second string:

"Example: SinchClient(..., sms_region='eu')"
" or set it via sinch_client.configuration.sms_region. "

Same fix needed in get_conversation_origin().

---

Issue 2: get_sinch_client() ignores its config parameter

File: examples/sinch_events/sinch_client_helper.py

The function signature accepts config: dict and the docstring says it returns a "configured Sinch client instance", but the body returns a bare SinchClient() with no arguments — the config dict is never used:

def get_sinch_client(config: dict) -> SinchClient:
    """Create and return a configured SinchClient instance."""
    return SinchClient()  # config is completely ignored

This means any user extending this example to make outbound API calls will get a client with no credentials.

Fix: Pass the config values to SinchClient(), e.g.:

return SinchClient(
    project_id=config.get("project_id"),
    key_id=config.get("key_id"),
    key_secret=config.get("key_secret"),
)

🤖 Generated with Claude Code