Open
Conversation
* Add missing implementations * Bump SDK version
Co-authored-by: Vincent Davis <vincent@heteroskedastic.net>
Co-authored by: @vincentdavis
matsk-sinch
requested review from
JPPortier,
asein-sinch and
rpredescu-sinch
as code owners
asein-sinch
reviewed
Mar 25, 2026
Comment on lines
-20
to
+21
| phone_number = os.environ.get("SINCH_PHONE_NUMBER") or "MY_SINCH_PHONE_NUMBER" | ||
| # The phone number to release in E.164 format | ||
| phone_number = os.environ.get("SINCH_PHONE_NUMBER") or "MY_PHONE_NUMBER" | ||
|
|
Contributor
There was a problem hiding this comment.
MY_SINCH_PHONE_NUMBER was better
Comment on lines
+21
to
+22
| # The display name to set for the number | ||
| display_name = "DISPLAY_NAME" |
Contributor
There was a problem hiding this comment.
Prefer Updated DISPLAY_NAME as it was before to reflect the output in the response printed at the end of the snippet
|
|
||
| hmac_secret = "NEW_HMAC_SECRET" | ||
| # The HMAC secret for signing webhook requests to your event destination | ||
| hmac_secret = "HMAC_SECRET" |
Contributor
There was a problem hiding this comment.
NEW_HMAC_SECRET was better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.