Add Paparazzi snapshot testing for UI tests#20
Add Paparazzi snapshot testing for UI tests#20firebender-bot[bot] wants to merge 3 commits intomainfrom
Conversation
? Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
|
The snapshots have a loading spinner and don’t verify the barcode fix this |
|
Firebender finished and opened a pull request: #20. Summary: Perfect! All changes are complete and tested. Here's a summary: SummaryI've successfully fixed the Paparazzi snapshot tests so they now capture actual barcodes instead of loading spinners. Changes Made1. Created
2. Updated all preview composables (
3. Updated app examples (
4. Updated documentation (
5. Regenerated all snapshots:
Test Results✅ Library tests passing: The snapshots now correctly capture the rendered barcodes for all types: QR Code, Code 128, Code 39, EAN-13, UPC-A, Data Matrix, Aztec, and PDF417. |
Introduced SynchronousBarcode composable for snapshot testing to ensure Paparazzi captures actual barcode images instead of loading states. Updated all preview functions and regenerated snapshots with actual barcode renders. ? Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review please |
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
This looks wrong and squished. It should be square.
There was a problem hiding this comment.
This should be more rectangular
There was a problem hiding this comment.
This should be more rectangular
There was a problem hiding this comment.
Remove this, it is not useful
There was a problem hiding this comment.
This feels too squished. It should be longer.
|
fix the review comments and clean up the code in general to be more production ready |
|
Firebender finished and opened a pull request: #20. Summary: Perfect! All review comments have been addressed and the code is now production ready. SummaryI've successfully fixed all PR review comments and cleaned up the code for production: Review Comments FixedRemoved SimplePreviewTest - Deleted the unnecessary test file and its snapshot as requested Fixed barcode aspect ratios:
Code Quality ImprovementsEnsured consistency - Added explicit Enhanced documentation:
Test Results✅ All 11 library snapshot tests passing: The snapshots now correctly render barcodes with proper aspect ratios - square codes stay square, and linear barcodes have appropriate width-to-height ratios. |
Align synchronous barcode dimensions with preview modifiers to keep rendered snapshots accurate, and remove the extra setup-only preview test now that the main snapshot suite fully covers the UI cases. ? Generated with [Firebender](https://firebender.com) Co-Authored-By: Firebender <help@firebender.com>
Summary
SynchronousBarcodewidth and height parameters with preview modifier sizes to preserve correct barcode aspect ratios across the recorded snapshotsSimplePreviewTest, regenerate the library snapshots, and document the sizing requirements in the Paparazzi setup notesTest plan
./gradlew :composed-barcodes:verifyPaparazziDebugFixes #19
? Generated with Firebender