Add sequence confidence to pretranslations#279
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 355 355
Lines 22801 22829 +28
=======================================
+ Hits 20862 20888 +26
- Misses 1939 1941 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and mshannon-sil).
machine/translation/translation_result.py line 55 at r1 (raw file):
@property def sequence_confidence(self) -> Optional[float]:
We should have a default value, so that the confidence isn't optional, i.e. -1.
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 made 1 comment.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on ddaspit and mshannon-sil).
machine/translation/translation_result.py line 55 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
We should have a default value, so that the confidence isn't optional, i.e.
-1.
Done. I moved the default value to the builder because we exponentiate the value when using the builder to create the result and it seemed a but cleaner this way. Would you prefer it here or in the builder?
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 4 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mshannon-sil).
machine/translation/translation_result.py line 55 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Done. I moved the default value to the builder because we exponentiate the value when using the builder to create the result and it seemed a but cleaner this way. Would you prefer it here or in the builder?
This is good.
Fixes #268, #271
See also sillsdev/silnlp#966 which came out of this work.
This change is