Skip to content

Revert tree expansion logical changes from SDK modernization commit#775

Open
jasonleenaylor wants to merge 1 commit intomainfrom
LT-22469
Open

Revert tree expansion logical changes from SDK modernization commit#775
jasonleenaylor wants to merge 1 commit intomainfrom
LT-22469

Conversation

@jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Mar 20, 2026

Reverts behavioral changes in 5711bf6 that were unconnected to the .NET modernization

  1. Slice.cs: Restore default-expand behavior (expansion != "doNotExpand") fix LT-22469
  2. StackDumperWin64.cpp: Restore SymGetLineFromAddr64 GetProcAddress loading
  3. StackDumper.cpp: Restore real stack capture via SEH in DumpStackHere

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 13s ⏱️ +24s
4 074 tests ±0  4 003 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 083 runs  ±0  4 012 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 214de97. ± Comparison against base commit b6ac397.

♻️ This comment has been updated with latest results.

1. Slice.cs: Restore expansion logic to != "doNotExpand" (expand by
   default) instead of == "expanded" (collapsed by default)
   This fixes LT-22469
@jasonleenaylor
Copy link
Contributor Author

I was also trying to get other changes into this PR initially, but they were harder to tease out. Splitting those into a follow up commit.

@jasonleenaylor jasonleenaylor changed the title Revert 3 unrelated logical changes from SDK modernization commit Revert tree expansion logical changes from SDK modernization commit Mar 20, 2026
@jasonleenaylor jasonleenaylor marked this pull request as ready for review March 20, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant