Conversation
|
@dkropachev Please review. |
| permissions: | ||
| contents: read | ||
|
|
There was a problem hiding this comment.
Interesting that here contents: write is not present. I'm even more curious now about why PRs in other repos have it.
There was a problem hiding this comment.
The docs-pr workflow doesn't need write permissions. It only builds the docs on new PRs for validation purposes.
The docs-pages workflow might need write permissions. Some repos (like this one) still use an older workflow that pushes to a github-pages branch, which requires contents: write. We propagated that permission from the theme repo, but it may not actually be necessary in repos using the newer GitHub Actions deploy workflow. I'll roll it back in those repos.
|
@dkropachev I don't know what is this |
Motivation
Updates docs theme to 1.9.
Changelog: https://github.com/scylladb/sphinx-scylladb-theme/blob/master/docs/source/upgrade/CHANGELOG.md#190---26-february-2026
How to test
Make sure you are using Python 3.11-3.14:
Install uv:
Build the docs:
Docs should render without errors at http://127.0.0.1:5500