Fix categorical color mapping across coordinate systems#547
Open
Fix categorical color mapping across coordinate systems#547
Conversation
…rdinate systems When plotting shapes colored by a categorical column across multiple coordinate systems, the color_source_vector could carry unused categories from other coordinate systems. This caused a length mismatch between categories and stored colors in adata.uns, leading to a ValueError in strict zip calls. The fix removes unused categories early in both _generate_base_categorial_color_mapping and _extract_colors_from_table_uns, and maps colors by the category's position in the full table (not the subset) to ensure consistent coloring across coordinate systems. Fixes #425 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
- Coverage 84.00% 83.86% -0.15%
==========================================
Files 9 9
Lines 2601 2609 +8
==========================================
+ Hits 2185 2188 +3
- Misses 416 421 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueError: zip() argument 2 is shorter than argument 1when plotting shapes colored by a categorical column across multiple coordinate systems with different category countsremove_unused_categories()early in_generate_base_categorial_color_mappingand_extract_colors_from_table_unsso that categories and stored.unscolors stay alignedFixes #425
Test plan
color="leiden"across multiple coordinate systems where category counts differ no longer crashes🤖 Generated with Claude Code