add callback back in L1ERC20GatewayValidium.finalizeWithdrawERC20#157
Merged
add callback back in L1ERC20GatewayValidium.finalizeWithdrawERC20#157
Conversation
Thegaram
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the missing
_doCallback(_to, _data)call inL1ERC20GatewayValidium.finalizeWithdrawERC20, ensuring that recipient callbacks are executed during ERC20 withdrawal finalization in the validium gateway. This restores expected behavior for contracts and recipients that rely on callback execution when processing withdrawals.