chore(vllm_batch): bump batch image to vLLM 0.17.1 for NVFP4 TP>1 fix#785
Open
chore(vllm_batch): bump batch image to vLLM 0.17.1 for NVFP4 TP>1 fix#785
Conversation
…d compat vLLM 0.17.0 removed --disable-log-requests from its arg parser, but model-engine hardcodes this flag when launching vllm_server. Accept the flag as a no-op when it's not present in the vLLM parser to avoid startup failures with newer vLLM images. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vLLM 0.17.1 adds explicit Nemotron-3-Super NVFP4 support and fixes accuracy with tensor parallelism > 1 (required for 4-GPU batch jobs). Image 0.17.1-batch built from vllm/vllm-openai:v0.17.1 and pushed to 692474966980.dkr.ecr.us-west-2.amazonaws.com/llm-engine/batch-infer-vllm:0.17.1-batch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vllm_batchandvllm_batch_v2image tags from0.17.0-rc1-batch→0.17.1-batchnum_shards=4)692474966980.dkr.ecr.us-west-2.amazonaws.com/llm-engine/batch-infer-vllm:0.17.1-batchBuild command
cd llm-engine ./model-engine/model_engine_server/inference/vllm/build_and_upload_image.sh \ batch vllm_batch \ --vllm-version=0.17.1 \ --vllm-base-image=vllm/vllm-openai:v0.17.1 \ --account=692474966980Test plan
0.17.1-batchtest_nemotron_super_120b_batch.pyend-to-end🤖 Generated with Claude Code
Greptile Summary
This PR bumps the
vllm_batchandvllm_batch_v2Helm values from0.17.0-rc1-batchto0.17.1-batchto pick up vLLM's official NVFP4 tensor-parallelism fix, and pairs the image bump with a small backward-compatibility shim invllm_server.pythat re-adds--disable-log-requestsas a silent no-op whenever the flag is absent from vLLM's own arg parser (it was removed in v0.17).charts/model-engine/values.yaml: bothvllm_batchandvllm_batch_v2tags updated from0.17.0-rc1-batch→0.17.1-batch.model-engine/model_engine_server/inference/vllm/vllm_server.py: defensiveif not any(...)guard checksparser._actionsbefore adding the deprecated flag, preventing a double-registration conflict if vLLM ever re-introduces the argument in a future version.Confidence Score: 5/5
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[parse_args called] --> B[make_arg_parser builds vLLM parser] B --> C{Is '--disable-log-requests'\nalready in parser._actions?} C -- Yes\n(vLLM re-added it) --> E[Skip — no duplicate registration] C -- No\n(vLLM v0.17+ removed it) --> D[Add '--disable-log-requests'\nas no-op action=store_true] D --> F[parser.parse_args] E --> F F --> G[Return args to caller]Reviews (1): Last reviewed commit: "chore(vllm_batch): bump batch image to v..." | Re-trigger Greptile