Conversation
ksss
left a comment
ksss
left a comment
There was a problem hiding this comment.
The test code differs significantly from the ruby/rbs version, making it difficult to pinpoint the differences.
Can it be made as close to the original as possible?
If there are issues with the original, please let me know.
sferik
force-pushed
the
add-rbs-signatures
branch
from
9c60307 to
1c7e9f0
Compare
sferik
force-pushed
the
add-rbs-signatures
branch
from
1c7e9f0 to
0533460
Compare
|
Okay, I've copied the tests from |
ksss
left a comment
ksss
left a comment
There was a problem hiding this comment.
NetHTTPTestSigHelper and NetHTTPRBSTestCase should be removed.
This approach does not allow us to confirm if the manifest.yaml specification is sufficient.
Additionally, library should be used.
This is a DSL that explicitly states that only the specified library has been loaded.
library "net-http"
testing "singleton(::Net::HTTP)"Replace custom NetHTTPTestSigHelper/NetHTTPRBSTestCase with the standard RBS::UnitTest library DSL, which validates that manifest.yaml declares all required dependencies.
|
@ksss How does that look? |
| dependencies: | ||
| - name: net-protocol | ||
| - name: open-uri | ||
| - name: openssl | ||
| - name: socket | ||
| - name: strscan | ||
| - name: timeout | ||
| - name: uri | ||
| - name: zlib |
There was a problem hiding this comment.
This is a list of libraries required on the Ruby side, and many of them are not necessary as RBS type names.
If you haven't added types to RBS, there should be no additional type names.
Please copy it as is.
| dependencies: | |
| - name: net-protocol | |
| - name: open-uri | |
| - name: openssl | |
| - name: socket | |
| - name: strscan | |
| - name: timeout | |
| - name: uri | |
| - name: zlib | |
| dependencies: | |
| - name: net-protocol | |
| - name: uri |
| gem "test-unit" | ||
| gem "test-unit-ruby-core" | ||
|
|
||
| group :sig do |
There was a problem hiding this comment.
This grouping is provided to avoid affecting existing Ruby code tests.
Existing test.yml and push_gem.yml workflows should avoid installing the sig group.
env:
BUNDLE_WITHOUT: sig2 participants
See #278 for context.