Skip to content

feat(make): Introduce olm-deploy goal, a one-shot OLM deployer#983

Open
olivergondza wants to merge 2 commits intoredhat-developer:masterfrom
olivergondza:old-deploy
Open

feat(make): Introduce olm-deploy goal, a one-shot OLM deployer#983
olivergondza wants to merge 2 commits intoredhat-developer:masterfrom
olivergondza:old-deploy

Conversation

@olivergondza
Copy link
Collaborator

@olivergondza olivergondza commented Oct 6, 2025

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test

/kind enhancement

/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Implements https://github.com/redhat-developer/gitops-operator/?tab=readme-ov-file#making-the-operator-available-on-the-in-cluster-operatorhub and https://github.com/redhat-developer/gitops-operator/?tab=readme-ov-file#re-build-and-deploy. Including waiting for operator to be up, and essential error reporting.

This builds and deploys new image/bundle/catalog, deploys it and waits for operator pod running. It is not needed to visit UI at all.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • [no] Documentation has been updated.

Which issue(s) this PR fixes:

None

Test acceptance criteria:

  • [n/a] Unit Test
  • [n/a] E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Oct 6, 2025
@openshift-ci openshift-ci bot requested review from jgwest and keithchong October 6, 2025 12:45
@olivergondza
Copy link
Collaborator Author

No changes related to the prod code, tests or their execution. Tests failures are unrelated.

@olivergondza
Copy link
Collaborator Author

@jgwest, can you please take a look?

@olivergondza
Copy link
Collaborator Author

@jgwest, @svghadi, please take a look if this is something we want in. (Asking before working on resolving conflicts)

olivergondza and others added 2 commits March 27, 2026 06:09
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
@jgwest
Copy link
Member

jgwest commented Mar 27, 2026

Rebased and added a comment to shell script.

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, LGTM, thanks @olivergondza!

@jgwest
Copy link
Member

jgwest commented Mar 27, 2026

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Member

jgwest commented Mar 27, 2026

Cluster init fail
/retest

@olivergondza
Copy link
Collaborator Author

@jgwest, Thanks for taking a look. Just pointing out that this make goal not utilized by CI, so whatever test results will be irrelevant to the changes reviewed. Can we only merge when tests are green?

@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2026

@olivergondza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential a23cefb link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants