feat(make): Introduce olm-deploy goal, a one-shot OLM deployer#983
feat(make): Introduce olm-deploy goal, a one-shot OLM deployer#983olivergondza wants to merge 2 commits intoredhat-developer:masterfrom
Conversation
d5b6a4f to
eb26790
Compare
|
No changes related to the prod code, tests or their execution. Tests failures are unrelated. |
eb26790 to
79ace96
Compare
|
@jgwest, can you please take a look? |
e778cdc to
618970b
Compare
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
|
Rebased and added a comment to shell script. |
jgwest
left a comment
There was a problem hiding this comment.
Works great, LGTM, thanks @olivergondza!
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgwest The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Cluster init fail |
|
@jgwest, Thanks for taking a look. Just pointing out that this make goal not utilized by CI, so whatever test results will be irrelevant to the changes reviewed. Can we only merge when tests are green? |
|
@olivergondza: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Implements https://github.com/redhat-developer/gitops-operator/?tab=readme-ov-file#making-the-operator-available-on-the-in-cluster-operatorhub and https://github.com/redhat-developer/gitops-operator/?tab=readme-ov-file#re-build-and-deploy. Including waiting for operator to be up, and essential error reporting.
This builds and deploys new image/bundle/catalog, deploys it and waits for operator pod running. It is not needed to visit UI at all.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
None
Test acceptance criteria:
How to test changes / Special notes to the reviewer: