fix: add podSecurityLabelSync=true to openshift-gitops#1105
fix: add podSecurityLabelSync=true to openshift-gitops#1105nmirasch wants to merge 3 commits intoredhat-developer:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @nmirasch. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| "pod-security.kubernetes.io/enforce": "privileged", | ||
| "pod-security.kubernetes.io/enforce-version": "v1.30", | ||
| "pod-security.kubernetes.io/audit": "privileged", | ||
| "pod-security.kubernetes.io/audit-version": "v1.29", | ||
| "pod-security.kubernetes.io/warn": "privileged", | ||
| "pod-security.kubernetes.io/warn-version": "v1.29", |
There was a problem hiding this comment.
Lets clean up the unit tests. We can not verify the label addition here so lets just focus on checking security.openshift.io/scc.podSecurityLabelSync label and remove others.
|
|
||
| By("OpenShift populates at least one pod-security.kubernetes.io/* label") | ||
| pssLabelKeys := []string{ | ||
| "pod-security.kubernetes.io/audit", |
There was a problem hiding this comment.
Let’s check for the restricted value in the audit labels. The version value can vary depending on the cluster, so it makes sense to skip validating it.
Verifying the restricted value should help us identify any behavioral changes in OCP in future.
nmirasch
force-pushed
the
GITOPS-9158_add_podSecurityLabelSync
branch
from
fcce172 to
7aaca66
Compare
|
@svghadi rebased! |
Signed-off-by: nmirasch <neus.miras@gmail.com>
Signed-off-by: nmirasch <neus.miras@gmail.com>
Signed-off-by: nmirasch <neus.miras@gmail.com>
nmirasch
force-pushed
the
GITOPS-9158_add_podSecurityLabelSync
branch
from
7aaca66 to
4451f4c
Compare
2 participants
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR delegate Pod Security Standards (PSS) labeling for OpenShift GitOps namespaces to the cluster.
The operator sets security.openshift.io/scc.podSecurityLabelSync=true on openshift-* namespaces and no longer applies hardcoded pod-security.kubernetes.io/* values itself.
Which issue(s) this PR fixes:
Fixes https://redhat.atlassian.net/browse/GITOPS-9158
Test acceptance criteria: