Open
Conversation
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
refactor-into-vmutils
branch
from
64839e5 to
9c71939
Compare
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
WaitSandbox API expects the exit code and exit timestamp in it's response. Therefore, adding and capturing the same to the actual compute system struct. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
There were few issues in the initial draft of guest manager code- - Guest connection listener was created during New method and then used in CreateConnection. This can be simplified by creating the listener prior to start accepting connections on the same. - Instead of hardcoding the GCS Service GUID, it can be made into a configurable parameter so that it can be used across shims. - Updation of HvSocket was needed only for WCOW and hence that responsibility can be deferred to the caller and hence hvSocket API was introduced. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
AcceptConnection method was incorrectly part of guestmanager package. Moreover, we needed stop time in SandboxWait API and hence the same is added to the manager. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
refactor-into-vmutils
branch
from
9c71939 to
ec90c3d
Compare
Start time is needed to be returned in the StartSandbox API and SandboxStatus API. Therefore, we need the plumbing for the same. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
`ExecIntoUVM` method is used to create an exec into the UVM by sending a request to GCS. In order to re-use the existing package, we have made minor refactor so that existing `cmd.ExecIntoUVM` method accepts the `cow.ProcessHost` interface that the UtilityVM instance. Since UtilityVM already conforms to ProcessHost, we can swap the same. With the refactor, the new shim can easily re-use the existing code in `cmd` package. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
…to use GuestConnection Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
…tils" This reverts commit 7ece36d. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
refactor-into-vmutils
branch
from
c7f79d8 to
3b03356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.