[executorch] Rewrite remove_unused_parameters_pass for HOP support#18145
Draft
GregoryComer wants to merge 1 commit intogh/GregoryComer/176/basefrom
Draft
[executorch] Rewrite remove_unused_parameters_pass for HOP support#18145GregoryComer wants to merge 1 commit intogh/GregoryComer/176/basefrom
GregoryComer wants to merge 1 commit intogh/GregoryComer/176/basefrom
Conversation
Update `remove_unused_parameters_pass` to handle HOP submodules. Use metadata from the `propagate_input_spec` pass to map placeholder nodes inside control flow branches (cond, map, scan, while_loop) to top-level inputs and remove unused ones, while making sure submodule signatures match HOP call nodes. The pass works via two sub-passes: * First, recursively find the set of all used parameters. * Second, recursively update HOP nodes and submodules to remove unused parameters. Differential Revision: [D95876981](https://our.internmc.facebook.com/intern/diff/D95876981/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18145
Note: Links to docs will display an error until the docs builds have been completed. ❌ 23 New Failures, 1 Unrelated FailureAs of commit fdbe8cf with merge base 48bd687 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 13, 2026
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Update
remove_unused_parameters_passto handle HOP submodules. Use metadata from thepropagate_input_specpass to map placeholder nodes inside control flow branches (cond, map, scan, while_loop) to top-level inputs and remove unused ones, while making sure submodule signatures match HOP call nodes.The pass works via two sub-passes:
Differential Revision: D95876981