Skip to content

Build QNN backend tests with EXTENSION_TENSOR, mark option as required#18140

Merged
GregoryComer merged 1 commit intopytorch:mainfrom
GregoryComer:qnn-test-build-fix
Mar 12, 2026
Merged

Build QNN backend tests with EXTENSION_TENSOR, mark option as required#18140
GregoryComer merged 1 commit intopytorch:mainfrom
GregoryComer:qnn-test-build-fix

Conversation

@GregoryComer
Copy link
Member

The QNN backend references extension_tensor and thus requires it to be built. This PR makes two changes:

  • Build extension_tensor in the backend test flow (unbreaks QNN jobs).
  • Mark the option as required to build QNN to give a nicer error message.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 12, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18140

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 284 Pending, 1 Unrelated Failure

As of commit 650f4be with merge base cc27e6b (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2026
@GregoryComer GregoryComer marked this pull request as ready for review March 12, 2026 22:57
@GregoryComer GregoryComer merged commit 6381e58 into pytorch:main Mar 12, 2026
302 of 322 checks passed
@manuelcandales
Copy link
Contributor

manuelcandales commented Mar 13, 2026

@pytorchbot cherry-pick --onto release/1.2 -c critical

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2026

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'testci' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@manuelcandales
Copy link
Contributor

@pytorchbot cherry-pick --onto release/1.2 -c critical

pytorchbot pushed a commit that referenced this pull request Mar 13, 2026
#18140)

The QNN backend references extension_tensor and thus requires it to be
built. This PR makes two changes:

* Build extension_tensor in the backend test flow (unbreaks QNN jobs).
* Mark the option as required to build QNN to give a nicer error
message.

(cherry picked from commit 6381e58)
@pytorchbot
Copy link
Collaborator

Cherry picking #18140

The cherry pick PR is at #18148 and it is recommended to link a critical cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants