Skip to content

Test windows schannel fix#18137

Open
digantdesai wants to merge 1 commit intomainfrom
schannel_ethos_fix
Open

Test windows schannel fix#18137
digantdesai wants to merge 1 commit intomainfrom
schannel_ethos_fix

Conversation

@digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Mar 12, 2026 •
edited
Loading

Fix for windows build failures,

Error: fatal: unable to access 'https://git.gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver.git/': schannel: next InitializeSecurityContext failed: SEC_E_ILLEGAL_MESSAGE (0x80090326) - This error usually occurs when a fatal SSL/TLS alert is received (e.g. handshake failed). More detail may be available in the Windows System event log.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 12, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18137

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 2 New Failures, 1 Pending

As of commit 2e5375d with merge base 96aeb57 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2026
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@digantdesai
Fix Windows CI schannel error for all windows jobs
2e5375d 
This is a temp fix.

Ask git to not use schannel and do
`git submodule update --init --recursive` manually in the job.
@digantdesai digantdesai marked this pull request as ready for review March 13, 2026 04:03
Copilot AI review requested due to automatic review settings March 13, 2026 04:03
Copilot AI reviewed Mar 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Windows CI workflows to avoid Git’s Schannel TLS backend issues by switching Git to the OpenSSL backend before initializing submodules, ensuring submodule checkout succeeds on affected Windows runners.

Changes:

  • Stop relying on the reusable windows_job.yml workflow’s submodules: recursive option for Windows jobs.
  • Add git config --global http.sslBackend openssl followed by git submodule update --init --recursive at the start of affected Windows job scripts.
  • Apply the same pattern across key Windows workflows (MSVC build, trunk Windows model tests, CUDA Windows E2E, build presets, and Windows unittest job).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/windows-msvc.yml Configures Git SSL backend and manually initializes submodules before MSVC build setup.
.github/workflows/trunk.yml Same Git SSL/submodule init adjustment for the Windows models test job.
.github/workflows/cuda-windows.yml Same Git SSL/submodule init adjustment for CUDA Windows E2E job.
.github/workflows/build-presets.yml Same Git SSL/submodule init adjustment for Windows preset builds.
.github/workflows/_unittest.yml Same Git SSL/submodule init adjustment for Windows unittests job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/_unittest.yml
script: |
git config --global http.sslBackend openssl
git submodule update --init --recursive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@digantdesai