Arm backend: Decompose where.ScalarOther for quantization support#18132
Open
YufengShi-dudu wants to merge 1 commit intopytorch:mainfrom
Open
Arm backend: Decompose where.ScalarOther for quantization support#18132YufengShi-dudu wants to merge 1 commit intopytorch:mainfrom
YufengShi-dudu wants to merge 1 commit intopytorch:mainfrom
Conversation
Arm quantizer does not annotate aten.where.ScalarOther, so where remains unquantized after it is rewritten to aten.where.self pre-QUANTIZE. Decompose where.ScalarOther(cond, x, s) into where.self(cond, x, full_like(x, s)) before QUANTIZE so existing where.self annotation can handle it. Change-Id: I82a7ffec5e3e037219ab7185d71371c7c14a5b4f Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18132
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 11 Pending, 15 Unrelated FailuresAs of commit 026943b with merge base 884ace9 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arm quantizer does not annotate aten.where.ScalarOther, so where remains unquantized after it is rewritten to aten.where.self pre-QUANTIZE.
Decompose where.ScalarOther(cond, x, s) into where.self(cond, x, full_like(x, s)) before QUANTIZE so existing where.self annotation can handle it.
Change-Id: I82a7ffec5e3e037219ab7185d71371c7c14a5b4f
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell