PEP 825: clarifications regarding value lists and merging metadata#4856
Open
mgorny wants to merge 3 commits intopython:mainfrom
Open
PEP 825: clarifications regarding value lists and merging metadata#4856mgorny wants to merge 3 commits intopython:mainfrom
mgorny wants to merge 3 commits intopython:mainfrom
Conversation
Signed-off-by: Michał Górny <mgorny@quansight.com>
This was essentially the goal, but I originally had trouble wording it properly. Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes)This PR aims to fill two gaps in the PEP:
variantsare technically sets, but since sets cannot be expressed in JSON, the spec used lists, but neglected to mention that they are sets. We changed that to explicitly say that, and mandated sorting them to make it possible to use plain equality comparison for the JSON. This matches how the reference implementation behaved.variants do not change" with plainer "result is the same irrespective of the order". Our original goal was to avoid ambiguity (such as two wheels having different order for the same namespaces that could lead to different results based on which data is used), and I think that's the easiest way to say that's not valid.
📚 Documentation preview 📚: https://pep-previews--4856.org.readthedocs.build/