Skip to content

Correct "arguments" to "parameters"#21004

Closed
hyperkai wants to merge 1 commit intopython:masterfrom
hyperkai:hyperkai-patch-14
Closed

Correct "arguments" to "parameters"#21004
hyperkai wants to merge 1 commit intopython:masterfrom
hyperkai:hyperkai-patch-14

Conversation

@hyperkai
Copy link
Contributor

Fix: #21003

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this passing without a code change? Could you look into why the tests are skipped

@hyperkai
Copy link
Contributor Author

hyperkai commented Mar 10, 2026

Why is this passing without a code change? Could you look into why the tests are skipped

"parse-errors.test" which I changed is excluded in testparse.py so the tests passed (are skipped).

@hauntsaninja
Copy link
Collaborator

No that's not why, there's separate logic for this. We'll do #21005 to ensure these tests are running in CI. Not much we can do beyond that, because these errors come from the underlying parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting only * to an empty parameter list gets a wrong error message saying "arguments" instead of "parameters"

2 participants