Add comment explaining two-step dependency installation in GitHub #20996
Open
dhanusharer wants to merge 1 commit intopython:masterfrom
Open
Add comment explaining two-step dependency installation in GitHub #20996dhanusharer wants to merge 1 commit intopython:masterfrom
dhanusharer wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
dhanusharer
changed the title
Collaborator
|
How does this improve reproducibility? This gets executed per run...? How does this improve debugging of deps? Does pip download not just result in a wheel, which has exactly the same files within as what eventually gets installed...? |
Contributor
|
If you ask an LLM to explain the reason behind something, it will just make something up 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a short comment explaining why the GitHub Action installs
dependencies using a two-step process (
pip downloadfollowed bypip install --find-links) instead of usingpip install .directly.Downloading dependencies first allows installation from local artifacts,
which improves reproducibility in CI environments and can make debugging
dependency resolution issues easier.
Closes #20990