gh-145685: Avoid contention on TYPE_LOCK in super() lookups#145775
Open
colesbury wants to merge 3 commits intopython:mainfrom
Open
gh-145685: Avoid contention on TYPE_LOCK in super() lookups#145775colesbury wants to merge 3 commits intopython:mainfrom
colesbury wants to merge 3 commits intopython:mainfrom
Conversation
mpage
approved these changes
Mar 10, 2026
Contributor
mpage
left a comment
There was a problem hiding this comment.
LGTM. Should we add a test to the scaling benchmark that reproduces the issue?
Objects/typeobject.c
Outdated
Comment on lines
+12371
to
+12372
| _PyThreadState_PushCStackRef(tstate, &mro_ref); | ||
| mro_ref.ref = PyStackRef_FromPyObjectNew(mro); |
Contributor
There was a problem hiding this comment.
Doesn't need to be in this PR, but would it be worth adding another function that combines these two operations?
Contributor
Author
There was a problem hiding this comment.
Yeah, makes sense.
Contributor
Author
|
This is enough to fix class Base:
def method(self):
return 1
class Derived(Base):
def method(self):
return super().method()
@register_benchmark
def super_call():
obj = Derived()
for _ in range(1000 * WORK_SCALE):
obj.method() |
Contributor
Author
|
Actually, maybe it's worth adding the different class benchmark now and I'll update it later. |
Fidget-Spinner
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyType_Lookup/_PyType_LookupStackRefAndVersion#145685