gh-128341: Simplify the definition of _Py_INTERNAL_ABI_SLOT and use it in stdlib modules#145770
Open
befeleme wants to merge 2 commits intopython:mainfrom
Open
gh-128341: Simplify the definition of _Py_INTERNAL_ABI_SLOT and use it in stdlib modules#145770befeleme wants to merge 2 commits intopython:mainfrom
befeleme wants to merge 2 commits intopython:mainfrom
Conversation
_PyABIInfo_DEFAULT is available in Include/modsupport.h, there's not need to duplicate the definition here. Rename from _Py_INTERNAL_ABI_SLOT, as it's no longer internal.
This enables running a check of ABI version compatibility. _tkinter, _tracemalloc and readline don't use the slots, hence they need explicit handling.
befeleme
requested review from
1st1,
AA-Turner,
AlexWaygood,
FFY00,
JelleZijlstra,
StanFromIreland,
abalkin,
ammaraskar,
asvetlov,
berkerpeksag,
brettcannon,
corona10,
emmatyping,
ericsnowcurrently,
erlend-aasland,
gpshead,
kumaraditya303,
lysnikolaou,
ncoghlan,
pablogsal,
pganssle,
picnixz,
rhettinger,
serhiy-storchaka,
warsaw and
willingc
as code owners
encukou
approved these changes
Mar 10, 2026
kumaraditya303
requested changes
Mar 10, 2026
| } | ||
|
|
||
| static struct PyModuleDef_Slot module_slots[] = { | ||
| _Py_ABI_SLOT, |
Contributor
There was a problem hiding this comment.
_asyncio is a builtin module as it is statically linked, this check is not needed as it is not a shared library module.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider discussing this in the issue linked, rather than it the PR, since this would ping a huge list of reviewers.