Add kitty keyboard protocol support to Unix _pyrepl#145759
Open
jechol wants to merge 1 commit intopython:mainfrom
Open
Add kitty keyboard protocol support to Unix _pyrepl#145759jechol wants to merge 1 commit intopython:mainfrom
jechol wants to merge 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VS Code 1.109 rolled out kitty keyboard protocol support in the integrated terminal via
terminal.integrated.enableKittyKeyboardProtocol. Once enabled, the program running in the terminal needs to request and understand the protocol itself._pyreplcurrently does not, which breaks the Unix/macOS Python REPL when keys start arriving as kitty keyboard sequences instead of legacy terminal input.This PR fixes that by teaching Unix
_pyreplto participate in the protocol and translate kitty key reports back into the existing_pyreplevent model._pyreplprepares the terminal and restore the previous keyboard mode on exitCSI u,CSI ~, andCSI 1;...key reports inunix_eventqueueand translate them into existing_pyreplkey eventsTests
./python.exe -m test -j1 test_pyrepl.test_eventqueue test_pyrepl.test_unix_console./python.exe -m test -j1 test_pyrepl.test_pyrepl