Skip to content

gh-142763: Fix race in ZoneInfo cache eviction#144978

Merged
colesbury merged 2 commits intopython:mainfrom
colesbury:gh-142763-zoneinfo-cache-race
Mar 10, 2026
Merged

gh-142763: Fix race in ZoneInfo cache eviction#144978
colesbury merged 2 commits intopython:mainfrom
colesbury:gh-142763-zoneinfo-cache-race

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 18, 2026

The cache may be cleared between the evaluation of the if statement and the call to popitem.

@colesbury colesbury marked this pull request as ready for review February 19, 2026 12:31
@colesbury colesbury requested a review from pganssle as a code owner February 19, 2026 12:31
@colesbury colesbury requested a review from Yhg1s February 19, 2026 12:32
@colesbury colesbury merged commit 665c1db into python:main Mar 10, 2026
53 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-142763-zoneinfo-cache-race branch March 10, 2026 18:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
The cache may be cleared between the evaluation of the if statement and the
call to popitem.
(cherry picked from commit 665c1db94f46f8e1a18a8c2f89adb3bc72cb83dc)

Co-authored-by: Sam Gross <colesbury@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2026
The cache may be cleared between the evaluation of the if statement and the
call to popitem.
(cherry picked from commit 665c1db94f46f8e1a18a8c2f89adb3bc72cb83dc)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 10, 2026

GH-145781 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 10, 2026
@bedevere-app
Copy link

bedevere-app bot commented Mar 10, 2026

GH-145782 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 10, 2026
colesbury added a commit that referenced this pull request Mar 10, 2026
…45782)

The cache may be cleared between the evaluation of the if statement and the
call to popitem.

(cherry picked from commit 665c1db)

Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit that referenced this pull request Mar 10, 2026
…45781)

The cache may be cleared between the evaluation of the if statement and the
call to popitem.

(cherry picked from commit 665c1db)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants