Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 4 4
Lines 86 86
Branches 17 15 -2
=======================================
Hits 83 83
Misses 2 2
Partials 1 1
🚀 New features to boost your workflow:
|
|
Please resolve git conflicts. |
|
"WIP for"... ha! that old... updating to use 'draft' instead. |
|
fwiw, twisted doesn't support sniffio yet. this was a place holder. |
|
A placeholder for: |
|
these certainly do all relate, though i don't recall all the details at this point. mostly we need to figure out the path in twisted. they are open to but not positive about this. regardless of where it's implemented it's dedicated functionality that is doing low level observations. i can see arguments for twisted not wanting to deal with this for the sake of not-twisted, though sure, it's easy to argue that cross compatibility via sniffio/anyio etc is good for everyone. and we did not want to implement the detection within sniffio due to the complexity of maintaining sensitive tooling outside of twisted repo where breaking changes would only be detected later. the way i see it is that regardless, this detection code is going to be 'ugly'... and as such, it's had a hard time finding a home. also i moved jobs years ago away from using twisted, and now have moved jobs again away from using python, so my drive to see this through waned. but, here i am... maybe i'll take another pass on the twisted PRs today. this explanation is just meant to be that, an explanation to share understanding. no frustration or passing the buck. thanks for your interest in this. |
https://twistedmatrix.com/trac/ticket/9815
twisted/twisted#1263
Draft for: