Skip to content

Completion refactors#1606

Merged
kmvanbrunt merged 5 commits intomainfrom
completion_refactors
Mar 14, 2026
Merged

Completion refactors#1606
kmvanbrunt merged 5 commits intomainfrom
completion_refactors

Conversation

@kmvanbrunt
Copy link
Member

  • Renamed Completions.completion_hint to hint.
  • Renamed Completions.completion_error to error.
  • Renamed Completions.completion_table to table and converted it from a string to a Rich Table.
  • Removed DEFAULT_TABLE_HEADER.
  • Renamed parser's table_header to table_columns.
  • Renamed CompletionItem.table_row to table_data.

Renamed completion_error to error.
Renamed completion_table to table and converted it from a string to a Rich Table.
Renamed CompletionItem's table_row to table_data.
@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.51%. Comparing base (a89beaf) to head (688bba7).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
- Coverage   99.53%   99.51%   -0.03%     
==========================================
  Files          21       21              
  Lines        4746     4755       +9     
==========================================
+ Hits         4724     4732       +8     
- Misses         22       23       +1     
Flag Coverage Δ
unittests 99.51% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmvanbrunt kmvanbrunt merged commit 9f8dbea into main Mar 14, 2026
32 of 33 checks passed
@tleonhardt tleonhardt deleted the completion_refactors branch March 14, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants