Lower bounds check on IntList get#1477
Open
smarasca5 wants to merge 2 commits intoprocessing:mainfrom
Open
Conversation
|
We might want to squash the commits into a single commit thaat has a more descriptive name. That way there's one commit with all the small changes packed together, so looking at the history it will be clear what happened here. |
|
@FranciscoJ26 could you please review these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Lower bounds check on IntList get
Resolves #[1415]
Changes: Added a lower bound within the if statement of the get method within IntList. There was no lower bounds check within this method before. Now it throws exception if index is negative.
Tests: tests within IntListTest
Checklist: Tests pass and branch is up to date