Require socket v2

[rodrigoaguilera]

Socket v1 gives a warning
Package league/uri-parser is abandoned, you should avoid using it. Use league/uri-interfaces instead.

From what I read the usage of socket here is compatible with version 2

[przepompownia]

From what I read the usage of socket here is compatible with version 2

Rather not: https://github.com/amphp/socket/blob/93ed36129dc54453803bb15282dfd1680c347836/composer.json#L35

[rodrigoaguilera]

Ok, so there usage of the amp library without declaring it directly as a dependency. I think that should be fixed here as well.

But this discovery turns this change into a bigger endeavor. Not sure if I have the time to commit to it. I was hoping it was an easy win 😅

[dantleech]

yeah, essentally Phpactor needs to be upgraded to use a new major version of AMP (using fibres) tbh I haven't even tryied to look at how much work that would be. Probably something that could be done wth Rector, but no small task.

[przepompownia]

If I'm not wrong, we need to upgrade three projects at once: this, phpactor and amp-fswatch. The last one seems to be easiest to check so I started rehearsing from it (phpactor/amp-fswatch#24). But as a newbie, I've had dozens of elementary examples to practice with along the way, especially comparing AMP2 vs. AMP3 vs. Revolt without AMP vs. pure Fiber. Language models are proving useful in providing such elementary examples, especially when the AMP documentation is incomplete. At this stage, I don't dare suggest mechanical changes via Rector. The lack of response means I'm spending less time on this topic, which doesn't mean I'm giving up.