Fix wrong type name in __repr__ TypeError message#678
Draft
jseop-lim wants to merge 1 commit intooracle:masterfrom
Draft
Fix wrong type name in __repr__ TypeError message#678jseop-lim wants to merge 1 commit intooracle:masterfrom
__repr__ TypeError message#678jseop-lim wants to merge 1 commit intooracle:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
__repr__ TypeError message
__repr__ TypeError message__repr__ TypeError message
08bf333 to
ec7b876
Compare
Signed-off-by: Jeongseop Lim <jseoplim@gmail.com>
ec7b876 to
d7e91a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #676.
When
__repr__returns a non-string value, theTypeErrormessage incorrectly reports the type of the object being repr'd instead of the return value's type, diverging from CPython.AS-IS
(type of the object)
TO-BE
(type of the return value, matching CPython)
Change
Pass
result(the__repr__return value) instead ofobj(the object being repr'd) toraiseTypeErrorinPyObjectReprAsObjectNode.java. The equivalent__str__path inPyObjectStrAsObjectNode.javaalready does this correctly.