Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Updates the experimental Boxcutter-based reconciliation path to align with a newer Boxcutter library release and accompanying dependency bumps.
Changes:
- Bump
pkg.package-operator.run/boxcuttertov0.11.0and adjust the ClusterExtensionRevision controller to use the updated revision/phase building APIs. - Update several Kubernetes module versions in
go.mod/go.sum. - Add a top-level
@WIPtag to the BoxcutterRuntime e2e feature.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
test/e2e/features/revision.feature |
Adds an @WIP tag to the ClusterExtensionRevision e2e feature file. |
internal/operator-controller/controllers/revision_engine_factory.go |
Updates Boxcutter engine construction to match new comparator/object-engine wiring. |
internal/operator-controller/controllers/clusterextensionrevision_controller.go |
Refactors revision construction to use NewRevisionWithOwner and phases-based helpers. |
go.mod |
Bumps Boxcutter and several k8s.io/* module versions. |
go.sum |
Updates module checksums for the Boxcutter bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/operator-controller/controllers/clusterextensionrevision_controller.go
Outdated
Show resolved
Hide resolved
620873f to
eb30d3a
Compare
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
eb30d3a to
de93b70
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
internal/operator-controller/controllers/clusterextensionrevision_controller.go:149
- The error message here still says "converting to boxcutter revision", but the helper was renamed to
buildBoxcutterPhasesand now returns phases/options (not a revision). Updating the message will make failures easier to understand and debug (e.g., "building boxcutter phases").
phases, opts, err := c.buildBoxcutterPhases(ctx, cer)
if err != nil {
setRetryingConditions(cer, err.Error())
return ctrl.Result{}, fmt.Errorf("converting to boxcutter revision: %v", err)
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
==========================================
- Coverage 68.60% 64.30% -4.30%
==========================================
Files 131 131
Lines 9330 9333 +3
==========================================
- Hits 6401 6002 -399
- Misses 2438 2854 +416
+ Partials 491 477 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
de93b70 to
4568526
Compare
|
Looks good from my end :) |
4568526 to
de93b70
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
internal/operator-controller/controllers/clusterextensionrevision_controller.go:149
- The error returned from
buildBoxcutterPhasesis being re-wrapped with%vand an outdated message ("converting to boxcutter revision"). Consider updating the message to reflect that this step builds phases/options, and use%wso callers can unwrap the original error for classification/logging.
phases, opts, err := c.buildBoxcutterPhases(ctx, cer)
if err != nil {
setRetryingConditions(cer, err.Error())
return ctrl.Result{}, fmt.Errorf("converting to boxcutter revision: %v", err)
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updates boxcutter library to v0.11.0 and adjusts code to accept the breaking changes. Signed-off-by: Daniel Franz <dfranz@redhat.com>
de93b70 to
e1a07cf
Compare
|
Whoops, sorry for erasing then re-applying your changes @perdasilva 😵 I had a combo of the github page not showing your changes and my local branch having a diff from upstream so I just assumed I had forgotten to push something. The branch should be identical now to your push, though. |
Description
Updates boxcutter library to (breaking) version v0.11.0.
Reviewer Checklist