Skip to content

🌱 Boxcutter Library Update#2554

Open
dtfranz wants to merge 1 commit intooperator-framework:mainfrom
dtfranz:boxcutter-update
Open

🌱 Boxcutter Library Update#2554
dtfranz wants to merge 1 commit intooperator-framework:mainfrom
dtfranz:boxcutter-update

Conversation

@dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Mar 11, 2026

Description

Updates boxcutter library to (breaking) version v0.11.0.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings March 11, 2026 08:38
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the experimental Boxcutter-based reconciliation path to align with a newer Boxcutter library release and accompanying dependency bumps.

Changes:

  • Bump pkg.package-operator.run/boxcutter to v0.11.0 and adjust the ClusterExtensionRevision controller to use the updated revision/phase building APIs.
  • Update several Kubernetes module versions in go.mod/go.sum.
  • Add a top-level @WIP tag to the BoxcutterRuntime e2e feature.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/e2e/features/revision.feature Adds an @WIP tag to the ClusterExtensionRevision e2e feature file.
internal/operator-controller/controllers/revision_engine_factory.go Updates Boxcutter engine construction to match new comparator/object-engine wiring.
internal/operator-controller/controllers/clusterextensionrevision_controller.go Refactors revision construction to use NewRevisionWithOwner and phases-based helpers.
go.mod Bumps Boxcutter and several k8s.io/* module versions.
go.sum Updates module checksums for the Boxcutter bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@netlify
Copy link

netlify bot commented Mar 11, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e1a07cf
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69b20cff46c6c80008ede526
😎 Deploy Preview https://deploy-preview-2554--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI review requested due to automatic review settings March 11, 2026 09:49
@dtfranz dtfranz marked this pull request as ready for review March 11, 2026 09:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

internal/operator-controller/controllers/clusterextensionrevision_controller.go:149

  • The error message here still says "converting to boxcutter revision", but the helper was renamed to buildBoxcutterPhases and now returns phases/options (not a revision). Updating the message will make failures easier to understand and debug (e.g., "building boxcutter phases").
	phases, opts, err := c.buildBoxcutterPhases(ctx, cer)
	if err != nil {
		setRetryingConditions(cer, err.Error())
		return ctrl.Result{}, fmt.Errorf("converting to boxcutter revision: %v", err)
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.30%. Comparing base (6f23a79) to head (e1a07cf).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...-controller/controllers/revision_engine_factory.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2554      +/-   ##
==========================================
- Coverage   68.60%   64.30%   -4.30%     
==========================================
  Files         131      131              
  Lines        9330     9333       +3     
==========================================
- Hits         6401     6002     -399     
- Misses       2438     2854     +416     
+ Partials      491      477      -14     
Flag Coverage Δ
e2e 42.21% <0.00%> (-0.05%) ⬇️
experimental-e2e 11.82% <0.00%> (-39.76%) ⬇️
unit 53.84% <95.45%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thetechnick
Copy link
Contributor

Looks good from my end :)

Copilot AI review requested due to automatic review settings March 12, 2026 00:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

internal/operator-controller/controllers/clusterextensionrevision_controller.go:149

  • The error returned from buildBoxcutterPhases is being re-wrapped with %v and an outdated message ("converting to boxcutter revision"). Consider updating the message to reflect that this step builds phases/options, and use %w so callers can unwrap the original error for classification/logging.
	phases, opts, err := c.buildBoxcutterPhases(ctx, cer)
	if err != nil {
		setRetryingConditions(cer, err.Error())
		return ctrl.Result{}, fmt.Errorf("converting to boxcutter revision: %v", err)
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Updates boxcutter library to v0.11.0 and adjusts code to accept the breaking changes.

Signed-off-by: Daniel Franz <dfranz@redhat.com>
@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 12, 2026

Whoops, sorry for erasing then re-applying your changes @perdasilva 😵 I had a combo of the github page not showing your changes and my local branch having a diff from upstream so I just assumed I had forgotten to push something. The branch should be identical now to your push, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants