NO-JIRA: Set agent DISABLE_IMAGE_POLICY for local installs#1867
NO-JIRA: Set agent DISABLE_IMAGE_POLICY for local installs#1867bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
/lgtm |
16b77c1 to
37ad98f
Compare
|
New changes are detected. LGTM label has been removed. |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I've tested this with: OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY is not set and not needed for install.
OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY not needed for install. OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY set and needed for install, otherwise installation will fail. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In CI, for agent-based installations the environment variable OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY is set and this is passed down to assisted-service. When doing local testing we also need to set this environment variable.